Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Access Control for Network Interface #683

Merged
merged 129 commits into from
Apr 16, 2024
Merged

Added Access Control for Network Interface #683

merged 129 commits into from
Apr 16, 2024

Conversation

snehilzs
Copy link
Contributor

@snehilzs snehilzs commented Jan 26, 2024 •
edited
Loading

Added initial modules for issue #682

@OlivierHecart
Code move
66f41d8
@OlivierHecart
Code move
ec960ea
@OlivierHecart
Use RoutingContext type
939daa4
@OlivierHecart
Structs split
6e1c124
@OlivierHecart
Renaming
239d8cb
@OlivierHecart
Visibility
b0f999b
@OlivierHecart
Move ingress/egress filters out of pubsub
2a5466b
@OlivierHecart
Make hat abstract
0f2fa24
@OlivierHecart
Abstract missing close_face fn
002db77
@OlivierHecart
Duplicate hat
a33fcf1
@OlivierHecart
Move Primitives
6b61780
@OlivierHecart
Move link_id into HatFace
0a76ae3
@OlivierHecart
Change face initialization
ef541d8
@OlivierHecart
Interceptors
1755ba9
@OlivierHecart
Interceptor types renaming
cb693dc
@OlivierHecart
Rename RoutingContext
c520168
@OlivierHecart
Add RoutingContext and LoggerInterceptor
a4a672e
@OlivierHecart
Interceptors can access the Config at construction
59e8de7
@OlivierHecart
Split linkstate and p2p peer hats
9c94df5
@OlivierHecart
Simplify HatTrait init function
0096e59
@OlivierHecart
Hats cleanup
d4fac3d
@OlivierHecart
Reintroduce routes precomputation
7c8732c
@OlivierHecart
Improve routes precomputation
b2a7ee2
@OlivierHecart
Reintroduce matching pulls precomputation
43fcb78
@OlivierHecart
Perf improvements
7cd513a
@OlivierHecart
Perf improvements
b530da2
@OlivierHecart
Merge branch 'master' into router-reorg
05e9c3b
@OlivierHecart
Remove files wrongly reintroduced by merge
d5fcdfa
@OlivierHecart
Fix complete_n build
331cb3f
@OlivierHecart
Remove useless checks
458e64c
@Mallets Mallets changed the base branch from main_old to main April 11, 2024 08:41
@snehilzs snehilzs requested a review from sashacmc April 11, 2024 18:01
sashacmc
sashacmc reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@sashacmc sashacmc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some small notes, all others LGTM

DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
zenoh/src/net/routing/interceptor/access_control.rs Show resolved Hide resolved
zenoh/src/net/routing/interceptor/authorization.rs Outdated Show resolved Hide resolved
@snehilzs snehilzs requested a review from Mallets April 12, 2024 13:18
sashacmc
sashacmc reviewed Apr 15, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
skreborn
skreborn reviewed Apr 16, 2024
View reviewed changes
DEFAULT_CONFIG.json5 Outdated Show resolved Hide resolved
@Mallets
Copy link
Member

Mallets commented Apr 16, 2024

@snehilzs in log messages would be nice to also show the name of the interface

@Mallets Mallets enabled auto-merge (squash) April 16, 2024 17:31
@Mallets Mallets merged commit 23c5932 into eclipse-zenoh:main Apr 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashacmc sashacmc sashacmc approved these changes

@skreborn skreborn skreborn left review comments

@Mallets Mallets Mallets approved these changes

Assignees

@snehilzs snehilzs

Labels
None yet
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Access Control features
7 participants
@snehilzs @Mallets @skreborn @sashacmc @OlivierHecart @kauncoder @fuzzypixelz